fix: move NULL messages under Debug log level #778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burningalchemist
changed the title
burningalchemist
changed the title
a-monteiro
pushed a commit
to duneanalytics/sql_exporter
that referenced
this pull request
Jul 27, 2025
fix: move NULL messages to Debug log level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a minor change to the logging level in the
scanRowmethod of thequery.gofile. It adjusts the log level fromWarntoDebugfor cases where key, time, or value columns areNULL. This should reduce the amount of unnecessarily rendered logs.query.go: Changed the log level fromslog.Warntoslog.Debugfor better granularity when loggingNULLvalues in key, time, and value columns within thescanRowmethod.