-
Notifications
You must be signed in to change notification settings - Fork 1
PHP technical committee RFC #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing words!
I think a couple technicalities should be thought about first before being released to the public in how membership is handled.
But in general looks good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me! A couple of minor comments and nits but then I think it should be good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've provided a few changes to either clean up grammar (I'm a native English speaker), or to make the text more clear.
I've also provided some questions that I think are likely to be asked earlier rather than later, and which you might want to address before taking it to the internals list.
This RFC proposes an introduction of the PHP Technical Committee (TC) that would decide about all technical aspects of | ||
php-src when there is a disagreements between core developers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This RFC proposes an introduction of the PHP Technical Committee (TC) that would decide about all technical aspects of | |
php-src when there is a disagreements between core developers. | |
This RFC proposes an introduction of the PHP Technical Committee (TC) that would mediate code contribution conflicts between core developers proposing or committing changes to php-src. |
"Decide about all technical aspects" is vague and will be argued back and forth. The goal is to mediate conflict which arise due to changes to php-src.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The technical aspects are actual defined so it should be clear what it is and if it is not, we should update the definition. The current statement is more vague IMO as it basically covers RFC proposed changes which is explicitly limited later in the RFC. It means that TC should never decide about commits that introduce user visible changes unless there are technical issues with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw. I'm fine if this gets rephrased in the way that will still make clear that the RFC user visible changes are not part of the decision.
Co-authored-by: George Peter Banyard <[email protected]>
Co-authored-by: George Peter Banyard <[email protected]>
…h of them. Also, GitHub does, too.
Co-authored-by: Jakub Zelenka <[email protected]>
Co-authored-by: Ilija Tovilo <[email protected]>
Co-authored-by: George Peter Banyard <[email protected]>
Co-authored-by: Larry Garfield <[email protected]>
Co-authored-by: Larry Garfield <[email protected]>
Co-authored-by: Larry Garfield <[email protected]>
Co-authored-by: Matthew Weier O'Phinney <[email protected]>
Co-authored-by: Matthew Weier O'Phinney <[email protected]>
Co-authored-by: Matthew Weier O'Phinney <[email protected]>
Co-authored-by: Matthew Weier O'Phinney <[email protected]>
Co-authored-by: Tim Düsterhus <[email protected]>
This is just to leave comments on the specific parts of text for PHP technical committee RFC: https://wiki.php.net/rfc/php_technical_committee