Don't create an ephemeral builder if it isn't truly needed

[natalieparellano]

Fixes #2195

Summary

Output

Before

After

Documentation

• Should this change be documented?
  • Yes, see #___
  • No

Related

Resolves #___

[codecov]

Codecov Report

Attention: Patch coverage is 68.75000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 70.16%. Comparing base (2fa3260) to head (376513b).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2196      +/-   ##
==========================================
- Coverage   70.17%   70.16%   -0.01%     
==========================================
  Files         253      253              
  Lines       18452    18495      +43     
==========================================
+ Hits        12947    12975      +28     
- Misses       4659     4671      +12     
- Partials      846      849       +3     

Flag	Coverage Δ
os_linux	69.30% <68.75%> (+0.03%)	⬆️
os_macos-arm64	65.62% <68.75%> (+0.02%)	⬆️
os_windows	69.68% <68.75%> (-0.01%)	⬇️
unit	70.16% <68.75%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[jjbustamante]

Do we have an acceptance test covering this scenario? The only thing that comes to my mind is we are not trying to save the ephemeral builder at some point during the build and we end up introducing some bug

[jjbustamante]

LGTM

My only concern is to double-check the acceptance test coverage

[natalieparellano]

Do we have an acceptance test covering this scenario?

I didn't add an explicit test for this, because I am lazy (and also because our current suite is long enough) but the tests were failing before I added 423f596 because we were cleaning up the original builder, making it unavailable for other tests.

[jjbustamante]

Do we have an acceptance test covering this scenario?

I didn't add an explicit test for this, because I am lazy (and also because our current suite is long enough) but the tests were failing before I added 423f596 because we were cleaning up the original builder, making it unavailable for other tests.

Then I am ok with it