Building darwin arm64 binaries by default on CI and amd64 during releases#2166
Merged
jjbustamante merged 1 commit intomainfrom May 24, 2024
Merged
Building darwin arm64 binaries by default on CI and amd64 during releases#2166jjbustamante merged 1 commit intomainfrom
jjbustamante merged 1 commit intomainfrom
Conversation
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
github-actions
Bot
added
the
type/chore
Comment on lines
+26
to
+27
| # since macos-14 the latest runner is arm64 | ||
| os: macos-arm64 |
Member
There was a problem hiding this comment.
Can we be certain that we'll always land on a macos-14 runner? Is it deterministic?
Member
Author
There was a problem hiding this comment.
well, until the latest runner is updated I think the answer is yes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
By default we will built
darwin/arm64binaries during CI anddarwing/amd64binaries during release, because the new macos runner is based onarmarchitectureOutput
Before
This is a image from our last PR before releasing
0.34.0-rc1themacosbinary is actually anarm64binary instead ofamd64After
Now, we actually saved the binary as
arm64and theamd64will be built laterDocumentation
Related
Resolves #2167