Warn misconfiguration keys in project.toml only for tables we own#2155
Merged
jjbustamante merged 3 commits intobuildpacks:mainfrom May 20, 2024
Merged
Conversation
jkutner
reviewed
May 17, 2024
jkutner
reviewed
May 17, 2024
… for tables in the project.toml we own Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
9c95d67 to
f733a3a
Compare
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With pack PR 2042 we added a warning message when unsupported keys are declared in
project.toml, the problem was that our spec allow the end-users to extend the file outside allnon-_table and this shouldn't print a warningOutput
Before
Any
project.tomlversion 0.1 or 0.2 with something like declaredWill print a warning message
After
We will only print a warning message for keys under
_.*that are not supported or ifbuildpack.iois being used and not valid, everything else will be ignoreDocumentation
Related
Resolves #1922