Separate suggested builders from default trusted builders#2043
Merged
jjbustamante merged 5 commits intobuildpacks:mainfrom Feb 7, 2024
Merged
Conversation
Signed-off-by: Colin Casey <casey.colin@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2043 +/- ##
==========================================
+ Coverage 79.63% 79.64% +0.01%
==========================================
Files 176 176
Lines 13214 13220 +6
==========================================
+ Hits 10522 10528 +6
Misses 2022 2022
Partials 670 670
Flags with carried forward coverage won't be shown. Click here to find out more. |
joshwlewis
reviewed
Feb 2, 2024
Signed-off-by: Colin Casey <casey.colin@gmail.com>
jjbustamante
approved these changes
Feb 7, 2024
Member
jjbustamante
left a comment
There was a problem hiding this comment.
Awesome!
Thanks @colincasey
This was referenced Jul 3, 2024
colincasey
added a commit
to colincasey/pack
that referenced
this pull request
Jul 4, 2024
…ed builders and trusted builders, there were several places that still had logic referencing suggested builders in the trusted context. This PR updates those code paths to only consider trusted builders and extracts out a shared function `IsKnownTrustedBuilder` that can be used for "is this a trusted builder" checks. Fixes buildpacks#2198 Signed-off-by: Colin Casey <casey.colin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the
SuggestedBuilderstruct with aKnownBuilderstruct that contains the same details + the following boolean flags:SuggestedTrustedThese flags can be set on a
KnownBuilderto control if it should be displayed as a suggested builder and/or be added as a default trusted builder.With these changes,
heroku/builder:20has also been removed from the suggested list but remains as a default trusted builder.Output
pack builder suggestBefore
After
pack config trusted-builders list(no difference since the default list is still all trusted)Before
After
Documentation
Related
Resolves #1500