add support to override UID for container#2017
Merged
jjbustamante merged 3 commits intobuildpacks:mainfrom Jan 19, 2024
Merged
Conversation
Signed-off-by: Parthiba-Hazra <parthibahazra@gmail.com>
github-actions
Bot
added
the
type/enhancement
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2017 +/- ##
==========================================
- Coverage 79.50% 79.49% -0.01%
==========================================
Files 175 175
Lines 13114 13135 +21
==========================================
+ Hits 10425 10440 +15
- Misses 2022 2026 +4
- Partials 667 669 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
|
@Parthiba-Hazra - thanks a lot for this. Is it possible to add a test in lifecycle_execution_test.go? If you search for |
Signed-off-by: Parthiba-Hazra <parthibahazra@gmail.com>
github-actions
Bot
added
the
type/chore
natalieparellano
approved these changes
Jan 19, 2024
github-actions
Bot
removed
the
type/chore
jjbustamante
approved these changes
Jan 19, 2024
Member
jjbustamante
left a comment
jjbustamante
left a comment
There was a problem hiding this comment.
@Parthiba-Hazra great work! thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here in the pr I simply add a flag --uid to override uid for container and keep the implementation same as gid, as a new contributor to buildpack project I might be missing some points .. A swift review or guidance would greatly assist me in diving into this project.
Resolves #1347