Fetch lifecycle binaries from lifecycle image #2007
Merged
jjbustamante merged 2 commits intomainfrom Dec 20, 2023
Merged
Conversation
github-actions
Bot
added
the
type/enhancement
natalieparellano
force-pushed
the
fix/extender-no-such-file
branch
from
4cc60a6 to
e52a3e0
Compare
…tainer Hopefully fixes missing file issues on Linux Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
fix/extender-no-such-file
branch
from
e52a3e0 to
4d8de33
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2007 +/- ##
==========================================
- Coverage 80.45% 79.69% -0.75%
==========================================
Files 172 172
Lines 12926 13046 +120
==========================================
- Hits 10398 10396 -2
- Misses 1874 1995 +121
- Partials 654 655 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fetch lifecycle binaries from lifecycle image instead of restorer container
Hopefully fixes missing file issues on Linux (see #1979)
Before
Before, we copied the lifecycle binaries out of the restorer container and mounted them back during the extend (run) phase.
After
Now, we download the lifecycle image from the daemon, fetch the lifecycle layer, and create an ephemeral run image that has the lifecycle layer added.
Documentation
Related
Resolves #1979 (I hope)