Replace github.com/ghodss/yaml with gopkg.in/yaml.v3#1984
Merged
jjbustamante merged 1 commit intobuildpacks:mainfrom Nov 20, 2023
Juneezee:chore/yaml
Merged
Replace github.com/ghodss/yaml with gopkg.in/yaml.v3#1984jjbustamante merged 1 commit intobuildpacks:mainfrom Juneezee:chore/yaml
github.com/ghodss/yaml with gopkg.in/yaml.v3#1984jjbustamante merged 1 commit intobuildpacks:mainfrom
Juneezee:chore/yaml
Conversation
At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. Since `github.com/ghodss/yaml` is only used in test files, we can safely replace it with `gopkg.in/yaml.v3`. The tests are still passing after the change. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
github-actions
Bot
added
type/enhancement
jjbustamante
added
dependencies
Member
|
@Juneezee Thanks for this PR! I just ran all the acceptance test locally and everything seems to be fine! |
jjbustamante
approved these changes
Nov 20, 2023
Member
jjbustamante
left a comment
jjbustamante
left a comment
There was a problem hiding this comment.
I tested locally. All good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently we are using two YAML libraries:
github.com/ghodss/yamlgopkg.in/yaml.v3At the time of making this commit, the package
github.com/ghodss/yamlis no longer actively maintained. There are numerous inquiries about the project's status on its issue tracker: https://github.com/ghodss/yaml/issues.Since
github.com/ghodss/yamlis only used in test files, we can safely replace it withgopkg.in/yaml.v3. The tests are still passing after the change.Output
Documentation
Related