New flatten buildpacks/builder implementation - Part 1 - removing depth#1925
Merged
jjbustamante merged 14 commits intomainfrom Dec 20, 2023
Merged
New flatten buildpacks/builder implementation - Part 1 - removing depth#1925jjbustamante merged 14 commits intomainfrom
jjbustamante merged 14 commits intomainfrom
Conversation
github-actions
Bot
added
the
type/enhancement
jjbustamante
added
flatten feature
experimental
Removing --depth flag Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
jjbustamante
force-pushed
the
enhancement/jjbustamante/flatten-1880/part-1
branch
from
398c8cd to
068d130
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1925 +/- ##
==========================================
- Coverage 79.64% 79.51% -0.12%
==========================================
Files 174 174
Lines 13126 13074 -52
==========================================
- Hits 10453 10395 -58
- Misses 2010 2016 +6
Partials 663 663
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
github-actions
Bot
added
the
type/chore
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
github-actions
Bot
removed
the
type/chore
Member
natalieparellano
left a comment
natalieparellano
left a comment
There was a problem hiding this comment.
Looks good @jjbustamante. I added one question to understand it better. It's nice to see all the complexity going away here. My apologies for being the person to suggest 'depth' in the first place.
Member
Author
|
@natalieparellano thanks for you feedback! I will take a look |
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
2 tasks
jjbustamante
deleted the
enhancement/jjbustamante/flatten-1880/part-1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
--depthflag frompack builder createandpack buildpack packagecommands, because it is not being used.Output
Before
pack builder createandpack buildpack packagecommands have the following flag:After
The flag is not available.
Documentation
Related
Resolves #1880