Skip to content

Flatten feature implementation#1914

Closed
dlion wants to merge 8 commits intobuildpacks:mainfrom
dlion:flatten-feature
Closed

Flatten feature implementation#1914
dlion wants to merge 8 commits intobuildpacks:mainfrom
dlion:flatten-feature

Conversation

@dlion
Copy link
Copy Markdown
Member

@dlion dlion commented Sep 20, 2023 •
edited
Loading

The aim of this PR is to implement the flatten feature into pack as specified in this RFC

I used a stacked PR to be able to remove the old flatten feature.
The base PR is here: #1912

Domenico Luciani added 3 commits September 20, 2023 16:20
Removed evry part of the code related with flatten feature
f6b70d7 
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Removed unused code and formatted
e971f6e 
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
WIP: Create a custom builder
3eff4a6 
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
@github-actions github-actions Bot added type/enhancement Issue that requests a new feature or improvement. type/chore Issue that requests non-user facing changes. labels Sep 20, 2023
@github-actions github-actions Bot added this to the 0.32.0 milestone Sep 20, 2023
Domenico Luciani and others added 4 commits September 21, 2023 18:02
WIP: FInishing up our flatten builder creation
bfb3a83 
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
@jjbustamante
Just making some changes to actually run the acceptance test
3b98352 
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Refactor test helper for creating flatten builder
208fc87 
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
Add first failing test for the flattener
4591bc8 
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
@dlion dlion mentioned this pull request Sep 28, 2023
Closed
2 tasks
Implemented descriptors and created a test for the open function
847948d 
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
@jjbustamante jjbustamante modified the milestones: 0.32.0, 0.33.0 Oct 17, 2023
@jjbustamante jjbustamante modified the milestones: 0.33.0, 0.32.0 Oct 31, 2023
@jjbustamante jjbustamante added flatten feature experimental Issue or PR refers to an experimental feature. and removed type/chore Issue that requests non-user facing changes. labels Nov 7, 2023
@jjbustamante jjbustamante removed this from the 0.33.0 milestone Nov 22, 2023
@jjbustamante
Copy link
Copy Markdown
Member

jjbustamante commented Nov 22, 2023

PR is still on draft, removing the milestone

@jjbustamante
Copy link
Copy Markdown
Member

jjbustamante commented Jan 22, 2024

Closing this PR in favor of #1985

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

experimental Issue or PR refers to an experimental feature. flatten feature type/enhancement Issue that requests a new feature or improvement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dlion @jjbustamante