Update acceptance fixtures to use newer Buildpack API versions#1913
Merged
Update acceptance fixtures to use newer Buildpack API versions#1913
Conversation
Lifecycle 0.18.0 and above will only support Buildpack API versions 0.7 and above Signed-off-by: Natalie Arellano <narellano@vmware.com>
github-actions
Bot
added
type/enhancement
jkutner
approved these changes
Sep 19, 2023
Comment on lines
-808
to
-813
| // extensions | ||
| assertImage.HasLabelWithData(builderName, "io.buildpacks.extension.layers", `{"read/env":{"read-env-version":{"api":"0.9","layerDiffID":"`+extReadEnvDiffID+`","name":"Read Env Extension"}},"simple/layers":{"simple-layers-version":{"api":"0.2","layerDiffID":"`+extSimpleLayersDiffID+`","name":"Simple Layers Extension"}}}`) | ||
| assertImage.HasLabelWithData(builderName, "io.buildpacks.buildpack.order-extensions", `[{"group":[{"id":"read/env","version":"read-env-version"},{"id":"simple/layers","version":"simple-layers-version"}]}]`) | ||
| // buildpacks | ||
| assertImage.HasLabelWithData(builderName, "io.buildpacks.buildpack.layers", `{"read/env":{"read-env-version":{"api":"0.2","stacks":[{"id":"pack.test.stack"}],"layerDiffID":"`+bpReadEnvDiffID+`","name":"Read Env Buildpack"}},"simple/layers":{"simple-layers-version":{"api":"0.2","stacks":[{"id":"pack.test.stack"}],"layerDiffID":"`+bpSimpleLayersDiffID+`","name":"Simple Layers Buildpack"}}}`) | ||
| assertImage.HasLabelWithData(builderName, "io.buildpacks.buildpack.order", `[{"group":[{"id":"read/env","version":"read-env-version","optional":true},{"id":"simple/layers","version":"simple-layers-version","optional":true}]}]`) |
Member
Author
There was a problem hiding this comment.
This does make our assertions weaker, but I'd argue it's okay because:
- It's unclear how much value we get from these assertions in the first place
- We're keeping the assertions for Linux containers
- Keeping the Windows assertions requires contributors to either have a Windows box OR they must let the tests fail not once, but twice in CI in order to grab the correct diffIDs ...this seems like an undue burden
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
update/bp-api
branch
from
44030d2 to
175282a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lifecycle 0.18.0 and above will only support Buildpack API versions 0.7 and above