Fixing out of memory using pack builder create on pack 0.30.0#1887
Merged
Fixing out of memory using pack builder create on pack 0.30.0#1887
pack builder create on pack 0.30.0#1887Conversation
f5b9076 to
241739e
Compare
241739e to
6e6d2a4
Compare
jkutner
approved these changes
Sep 6, 2023
d929148 to
a7e8c52
Compare
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
a7e8c52 to
5566436
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the uses of
io.ReadAll()when processing a tarball file forio.Copyand avoid trying to load a huge file in memoryOutput
Before
Running
pack builder createwith a buildpack containing a 4GB file on a host machine with limited memory (2GB) throwsStatus code: 137
After
The builder was created successfully
Documentation
Related
Resolves #1886