Conversation
added 3 commits
July 5, 2023 15:09
github-actions
Bot
added
type/enhancement
natalieparellano
commented
Jul 5, 2023
| return l.opts.RunImage | ||
| } | ||
| if amd.RunImage == nil { | ||
| if amd.RunImage == nil || amd.RunImage.Image == "" { |
Member
Author
There was a problem hiding this comment.
It looks like github.com/BurntSushi/toml had a bug before where empty structs without an omitempty annotation weren't getting written out to TOML files, so in our fixture file run-image was not present and amd.RunImage actually was nil. This change fixes the test no matter which version of the library we use.
cc @jkutner
…ound in existing metadata Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
commented
Jul 5, 2023
| "rebase", repoName, | ||
| "--run-image", runAfter, | ||
| "--pull-policy", "never", | ||
| "--force", |
Member
Author
There was a problem hiding this comment.
Worth noting, the need for --force is a breaking change. We should call this out in the release notes.
natalieparellano
force-pushed
the
bump-lifecycle
branch
from
60a8839 to
3ed108f
Compare
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
bump-lifecycle
branch
from
3ed108f to
0057769
Compare
Signed-off-by: Natalie Arellano <narellano@vmware.com>
jkutner
approved these changes
Jul 10, 2023
This was referenced Jul 10, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1826 +/- ##
==========================================
- Coverage 80.18% 80.16% -0.01%
==========================================
Files 169 169
Lines 12436 12436
==========================================
- Hits 9970 9968 -2
- Misses 1832 1834 +2
Partials 634 634
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.