Skip to content

Some fixes#1692

Merged
jkutner merged 8 commits intobuildpacks:mainfrom
chetanguptaa:some-fixes
Mar 31, 2023
Merged

Some fixes#1692
jkutner merged 8 commits intobuildpacks:mainfrom
chetanguptaa:some-fixes

Conversation

@chetanguptaa
Copy link
Copy Markdown
Contributor

Summary

Deleted a comment that I thought was no longer needed in builder.go

Output

Before

After

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #___

@chetanguptaa chetanguptaa requested review from a team as code owners March 29, 2023 17:46
@github-actions github-actions Bot added this to the 0.30.0 milestone Mar 29, 2023
@github-actions github-actions Bot added the type/enhancement Issue that requests a new feature or improvement. label Mar 29, 2023
@jjbustamante
Copy link
Copy Markdown
Member

@chetanguptaa please follow the steps to fix the DCO validation.

cubxxw and others added 6 commits March 30, 2023 19:45
… make it more readable

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: chetan gupta <chetangupta123raj@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: chetan gupta <chetangupta123raj@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: chetan gupta <chetangupta123raj@gmail.com>
Signed-off-by: chetan gupta <chetangupta123raj@gmail.com>
This reverts commit 54b9407.

Signed-off-by: chetan gupta <chetangupta123raj@gmail.com>
        updated builder.go

Signed-off-by: chetan gupta <chetangupta123raj@gmail.com>
@jkutner jkutner enabled auto-merge March 30, 2023 20:40
@jkutner jkutner merged commit 0f1a257 into buildpacks:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/enhancement Issue that requests a new feature or improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants