Implement RFC-0096 Remove Stacks & Mixins: phase 1#1660
Merged
Conversation
github-actions
Bot
added
the
type/enhancement
jkutner
force-pushed
the
jkutner/rfc-0096
branch
from
5c072f7 to
36284b6
Compare
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
jkutner
force-pushed
the
jkutner/rfc-0096
branch
from
36284b6 to
6034f55
Compare
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
natalieparellano
approved these changes
Mar 22, 2023
Member
natalieparellano
left a comment
natalieparellano
left a comment
There was a problem hiding this comment.
Looks good @jkutner!
| it("does not return an error", func() { | ||
| _, err := builder.New(baseImage, "some/builder") | ||
| h.AssertError(t, err, "image 'base/image' missing label 'io.buildpacks.stack.id'") | ||
| h.AssertNilE(t, err) |
Member
There was a problem hiding this comment.
Why don't we error here?
Member
Author
There was a problem hiding this comment.
@natalieparellano my thinking was that we want to allow images that don't have `io.buildpacks.stack.id label going forward
Member
There was a problem hiding this comment.
Ah, makes sense - I guess what threw me was the addition of and run image to the test description. I thought of a builder that is missing a run image reference.
Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Joe Kutner <jpkutner@gmail.com>
hone
approved these changes
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase of RFC #0096 - Remove Stacks & Mixins implementation.
Output
Before
Support
[stack]inbuilder.toml, and write/cnb/stack.toml` in builder.After
Support both
[stack]and[run]/[build]tables. If both are present,[run]/[build]take precedent. Stack ID will still be accepted.A
/cnb/stack.tomlwill be added to the builder if a Stack ID is provided. A/cnb/run.tomlmay also be added to the builder if[run]/[build]are definied.Documentation
Related
Resolves #___