Use arm64 lifecycle for arm64 linux base image#1521
Merged
sambhav merged 1 commit intobuildpacks:mainfrom Sep 29, 2022
jpena-r7:use-arm64-lifecycle-on-arm64
Merged
Use arm64 lifecycle for arm64 linux base image#1521sambhav merged 1 commit intobuildpacks:mainfrom jpena-r7:use-arm64-lifecycle-on-arm64
sambhav merged 1 commit intobuildpacks:mainfrom
jpena-r7:use-arm64-lifecycle-on-arm64
Conversation
Signed-off-by: Jerico Pena <jpena@rapid7.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1521 +/- ##
==========================================
- Coverage 81.14% 80.11% -1.02%
==========================================
Files 155 155
Lines 10086 10095 +9
==========================================
- Hits 8183 8087 -96
- Misses 1420 1524 +104
- Partials 483 484 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
jjbustamante
left a comment
There was a problem hiding this comment.
It looks awesome to me!!! Great job @jpena-r7!
jkutner
approved these changes
Sep 29, 2022
sambhav
approved these changes
Sep 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change installs the arm64 lifecycle when creating a builder on an arm64 linux base image. Tests were also added to verify expected behavior.
Unit and acceptance tests were run locally.
Output
Before
The current behavior is that it always downloads the x86-64 lifecycle.
After
I verified the correct behavior by building pack on an arm64 machine and creating a builder on an arm64 stack. See the output from a small script used to test the change below and the correct lifecycle url being used. it also verifies that the lifecycle binary can be executed inside the container.
Documentation
Related
Resolves #1518