Restructure pack client to pkg package

[jromero]

Summary

This is a major restructuring of certain packages to make them publically accessible as a go library.

It takes into consideration the proposed structure of RFC#82

Output

Before

.
├── acceptance
├── benchmarks
├── builder
├── buildpackage
├── cmd
│   └── pack
├── config
├── internal
│   ├── blob
│   ├── build
│   ├── builder
│   ├── buildpack
│   ├── buildpackage
│   ├── cache
│   ├── commands
│   ├── config
│   ├── container
│   ├── dist
│   ├── fakes
│   ├── image
│   ├── inspectimage
│   ├── layer
│   ├── logging
│   ├── name
│   ├── paths
│   ├── registry
│   ├── slices
│   ├── sshdialer
│   ├── stack
│   ├── strings
│   ├── stringset
│   ├── style
│   └── termui
├── logging
├── pkg
│   ├── archive
│   └── project
├── registry
├── resources
├── testdata
├── testhelpers
│   └── comparehelpers
├── testmocks
└── tools
    └── pedantic_imports

After

.
├── acceptance
├── benchmarks
├── builder
├── buildpackage
├── cmd
│   └── pack
├── internal
│   ├── build
│   ├── builder
│   ├── cache
│   ├── commands
│   ├── config
│   ├── container
│   ├── fakes
│   ├── inspectimage
│   ├── layer
│   ├── name
│   ├── paths
│   ├── registry
│   ├── slices
│   ├── sshdialer
│   ├── stack
│   ├── strings
│   ├── stringset
│   ├── style
│   ├── term
│   └── termui
├── pkg
│   ├── archive
│   ├── blob
│   ├── buildpack
│   ├── client
│   ├── dist
│   ├── image
│   ├── logging
│   ├── project
│   └── testmocks
├── registry
├── resources
├── testdata
├── testhelpers
│   └── comparehelpers
└── tools
    └── pedantic_imports

Documentation

• Should this change be documented?
  • Yes, see #___
  • No

Related

Resolves #1245

[codecov]

Codecov Report

Merging #1315 (7ee83ee) into main (c845240) will decrease coverage by 0.17%.
The diff coverage is 79.39%.

@@            Coverage Diff             @@
##             main    #1315      +/-   ##
==========================================
- Coverage   80.46%   80.29%   -0.16%     
==========================================
  Files         144      143       -1     
  Lines        9039     8998      -41     
==========================================
- Hits         7272     7224      -48     
- Misses       1301     1307       +6     
- Partials      466      467       +1     

Flag	Coverage Δ
os_linux	78.94% <79.39%> (-0.17%)	⬇️
os_macos	73.47% <78.63%> (-0.16%)	⬇️
os_windows	80.16% <79.39%> (-0.13%)	⬇️
unit	80.29% <79.39%> (-0.16%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[dfreilich]

One question - what do you think of folding together the internal/logging and pkg/logging package? I'd been planning on making a PR for that purpose, since it becomes non-trivial for a library user to manage the logs (i.e, if you just do pack.NewClient, you automatically get debug level logs, and it's not simple to ensure that you don't get it). That may deserve its own PR, though...

[jromero]

One question - what do you think of folding together the internal/logging and pkg/logging package? I'd been planning on making a PR for that purpose, since it becomes non-trivial for a library user to manage the logs (i.e, if you just do pack.NewClient, you automatically get debug level logs, and it's not simple to ensure that you don't get it). That may deserve its own PR, though...

I did actually do that as part of this PR but primarily because it caused a lot of circular dependencies. The plus side is the better UX as you mentioned.

The tree above had some dangling directories. Updating now...

[dfreilich]

I totally didn't see you merged this – fabulous, thank you!