Only add project-metadata source of type "project" when present#1285
Merged
jromero merged 1 commit intorelease/0.21.0from Sep 15, 2021
Merged
Only add project-metadata source of type "project" when present#1285jromero merged 1 commit intorelease/0.21.0from
jromero merged 1 commit intorelease/0.21.0from
Conversation
Also, make it experimental Signed-off-by: Javier Romero <rjavier@vmware.com>
Codecov Report
@@ Coverage Diff @@
## release/0.21.0 #1285 +/- ##
==================================================
+ Coverage 81.08% 81.09% +0.01%
==================================================
Files 143 143
Lines 8757 8761 +4
==================================================
+ Hits 7100 7104 +4
Misses 1218 1218
Partials 439 439
Flags with carried forward coverage won't be shown. Click here to find out more. |
aemengo
approved these changes
Sep 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pack will no longer produce project metadata source of type project when project descriptor is not present.
Additionally, this PR makes this feature as a whole experimental. Primarily because we are still missing the other types per #1139.
Output
Before
After
Documentation
Related
Related to #1138