Default to standard library when validating zip file#1238
Merged
jromero merged 1 commit intobuildpacks:mainfrom Aug 11, 2021
Merged
Default to standard library when validating zip file#1238jromero merged 1 commit intobuildpacks:mainfrom
jromero merged 1 commit intobuildpacks:mainfrom
Conversation
Signed-off-by: Anthony Emengo <aemengo@vmware.com>
github-actions
Bot
added
the
type/enhancement
jromero
approved these changes
Aug 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Go stdlib zip format validation looks non-trivial. Might be worth delegating..
Output
Before
$ pack build sample-app --path target/sample-0.0.1-SNAPSHOT.jar --builder cnbs/sample-builder:bionic ERROR: failed to build: invalid app path 'target/sample-0.0.1-SNAPSHOT.jar': app path must be a directory or zipAfter
Documentation
Related
Resolves #1236