Clean Filepaths to ensure no XSS (Polish PR for 1164 and 1155)#1188
Merged
Clean Filepaths to ensure no XSS (Polish PR for 1164 and 1155)#1188
Conversation
Signed-off-by: Rahul Grover <rahulgrover99@gmail.com>
Signed-off-by: Rahul Grover <rahulgrover99@gmail.com>
Signed-off-by: Rahul Grover <rahulgrover99@gmail.com>
Signed-off-by: Sonia Singla <soniasingla.1812@gmail.com>
A previous commit had restricted permissions on directories we create/move during our testing. Overall that is a very helpful process, but in this particular case, it was causing some of our ensuing code and tests to fail, given that they expected to be able to write to those directories; further, it was in a test context, where there is limited room for exposure of files. Given that, I've reverted this aspect of the PR. If someone wants to do a slower and more thorough analysis of the permissions we create, in order to ensure that they are appropriate and the most limited they can be, that would be gold. Signed-off-by: David Freilich <david.freilich@appsflyer.com>
github-actions
Bot
added
type/chore
github-actions
Bot
added
the
type/chore
dfreilich
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1188 +/- ##
=======================================
Coverage 80.83% 80.83%
=======================================
Files 136 136
Lines 8278 8278
=======================================
Hits 6691 6691
Misses 1159 1159
Partials 428 428
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a polish PR to incorporate the changes made in #1164 and #1155. One particular change in these PRs (for bugsbash) is that it reverts the changes made to the directory permissions – those cases were created and used in a testing context, so a) it broke the code, given that later parts of the program expected to write to those directories from a non-root user, and b) it is in a test, so it isn't quite as exposed as it would be otherwise.
Resolves #1164
Resolves #1155
Many thanks to @soniasingla and @rahulgrover99 for the work with this!