Create temporary registry cache alongside intended destination

[briandealwis]

Summary

Cause the temporary registry cache to be created alongside its eventual destination. If creating the temp directory fails, then the rename will likely fail too.

Before

$ TMPDIR=/run/user/609477/ pack build --builder=gcr.io/buildpacks/builder:v1 --buildpack=google.go.runtime@0.9.1 --buildpack google.go.build@0.9.0 --buildpack google.utils.label@0.0.1 --buildpack=cage1016/jq-cnb@1.1.0  -v testimg
[...[
Refreshing registry cache for github.com//buildpacks/registry-index
Creating registry cache for github.com//buildpacks/registry-index
ERROR: failed to build: locating in registry cage1016/jq-cnb@1.1.0: refreshing cache: initializing (/usr/local/google/home/bdealwis/.pack/registry-a932275bd19c2d9e1b88fa06698fd2f5427a363d25bf87fa500691c373089381): creating registry cache: rename /run/user/609477/registry038609750 /usr/local/google/home/bdealwis/.pack/registry-a932275bd19c2d9e1b88fa06698fd2f5427a363d25bf87fa500691c373089381: invalid cross-device link

After

$ TMPDIR=/run/user/609477/ ~/Projects/Buildpacks/repo-pack/pack build --builder=gcr.io/buildpacks/builder:v1 --buildpack=google.go.runtime@0.9.1 --buildpack google.go.build@0.9.0 --buildpack google.utils.label@0.0.1 --buildpack=cage1016/jq-cnb@1.1.0  -v testimg
[...]
Refreshing registry cache for github.com//buildpacks/registry-index
Creating registry cache for github.com//buildpacks/registry-index
Validating registry cache for github.com//buildpacks/registry-index
Creating registry cache for github.com//buildpacks/registry-index
Pulling image ghcr.io/cage1016/buildpacks/cage1016_jq-cnb@sha256:48755cd2fb2a18d9f6553791337d0141b220c69d711cbd8383f2cc94a0bcbb7e
[...continues to success...]

Documentation

• Should this change be documented?
  • Yes, see #___
  • No

Related

Resolves #1182

[codecov]

Codecov Report

Merging #1183 (6d431d5) into main (4037c9c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1183   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files         136      136           
  Lines        8278     8278           
=======================================
  Hits         6691     6691           
  Misses       1159     1159           
  Partials      428      428           

Flag	Coverage Δ
os_linux	80.38% <100.00%> (-0.04%)	⬇️
os_macos	77.95% <100.00%> (ø)
os_windows	80.75% <100.00%> (ø)
unit	80.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[jromero]

Thank you for the fix!

TIL: Rename limitations 😁