Conversation
Signed-off-by: dwillist <dthornton@vmware.com>
Signed-off-by: dwillist <dthornton@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #1051 +/- ##
==========================================
+ Coverage 80.52% 80.97% +0.46%
==========================================
Files 136 136
Lines 6050 8306 +2256
==========================================
+ Hits 4871 6725 +1854
- Misses 751 1156 +405
+ Partials 428 425 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
If there isn't expected to be a lifecycle update with buildpacks/lifecycle#520, should we defer this to the next milestone? |
|
@dfreilich sounds good 👍 |
|
Given the release of |
Signed-off-by: dwillist <dthornton@vmware.com>
|
Ping @dwillist 👋 Is this really ready to merge out are there any outstanding items? |
The conversation happened out of band, but word was it’s “just waiting for reviews” |
dfreilich
left a comment
There was a problem hiding this comment.
Overall, this looks great!
Quite a few of the changes were in adding a space before a comment, so there were fewer changes than I expected, and I'm sorry we didn't merge it in earlier!
Summary
implement changes needed to support platform api
0.6, Need to wait for a lifecycle release with buildpacks/lifecycle#520 to be merged and released before writing acceptance tests.Really this PR just makes the following changes in the codebase: