Conversation
Co-authored-by: jabrown85 <790999+jabrown85@users.noreply.github.com>
Co-authored-by: jabrown85 <790999+jabrown85@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update Go tooling to version 1.26.0
Upgrade Go to 1.26.0
Feb 10, 2026
Contributor
|
@copilot the actions are failing on your PR - investigate |
Co-authored-by: jabrown85 <790999+jabrown85@users.noreply.github.com>
Contributor
Author
Fixed in commit 8478c76. The build failure was caused by a non-constant format string in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
jabrown85
approved these changes
Feb 10, 2026
jjbustamante
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates Go toolchain from 1.25.6 to 1.26.0.
go.mod: Go directive updated to 1.26.0acceptance/testdata/launcher/Dockerfile: Base image updated togolang:1.26.0.github/workflows/test-s390x.yml: s390x binary download URL updated to go1.26.0Makefile: Launcher size limit increased from 3MB to 4MB (s390x binary is now 3.1MB; other architectures remain <3MB)platform/files/handle_toml.go: Fixed non-constant format string error - Go 1.26.0 enforces stricter security checks on formatted logging functions, requiring constant format stringsRelease notes
Updated Go to 1.26.0. The launcher binary size limit increased from 3MB to 4MB to accommodate s390x architecture. Fixed format string security issue for Go 1.26.0 compatibility.
Context
Binary sizes post-upgrade:
Go 1.26.0 introduced stricter security checks for formatted logging functions. The code in
platform/files/handle_toml.go:44was passing a non-constant string directly as the format string tologger.Debugf(), which is now flagged as a security issue. This was fixed by using a constant format string ("%s") with the dynamic content as an argument.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.