Change the output of import commands to return arrays - #365
Merged
Conversation
chenbh
requested changes
Nov 2, 2023
| err = json.Indent(&buf, data, "", " ") | ||
| if err != nil { | ||
| return err | ||
| for _, obj := range objs { |
Contributor
There was a problem hiding this comment.
Is this change needed? json.Marshal should automatically add the start and ending brackets when passed in a slice.
Contributor
Author
There was a problem hiding this comment.
Each object is json but the whole thing is not so if you try to marshal it, it fails
xtreme-shane-lattanzio
force-pushed
the
import_output
branch
from
November 14, 2023 21:18
acb1d85 to
81f9546
Compare
xtreme-shane-lattanzio
force-pushed
the
import_output
branch
from
November 14, 2023 21:30
81f9546 to
7aa3c91
Compare
neil-hickey
pushed a commit
to neil-hickey/kpack-cli
that referenced
this pull request
Jan 13, 2026
…/import_output Change the output of import commands to return arrays
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #167