Skip to content

[Issue 269] Print the build number on the console output after triggering the image build - #344

Merged
chenbh merged 3 commits into
buildpacks-community:mainfrom
Priyanka-Kotturi:Issue-269-add-buildid-for-kp-trigger
Aug 25, 2023
Merged

[Issue 269] Print the build number on the console output after triggering the image build #344
chenbh merged 3 commits into
buildpacks-community:mainfrom
Priyanka-Kotturi:Issue-269-add-buildid-for-kp-trigger

Conversation

@Priyanka-Kotturi

Copy link
Copy Markdown
Contributor

This pull request resolves Issue #269, printing the build number on the console output when we trigger the image build using the kp trigger command

@Priyanka-Kotturi
Priyanka-Kotturi requested a review from a team as a code owner August 21, 2023 08:57
Co-authored-by: Sasi Kumar
@Priyanka-Kotturi Priyanka-Kotturi changed the title Issue 269 Print the build number on the console output after triggering the image build [Issue 269] Print the build number on the console output after triggering the image build Aug 23, 2023

@chenbh chenbh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a small change to avoid hard coding the annotation key

Comment thread pkg/commands/image/trigger.go Outdated
Comment thread pkg/commands/image/trigger.go Outdated
@Priyanka-Kotturi
Priyanka-Kotturi force-pushed the Issue-269-add-buildid-for-kp-trigger branch 2 times, most recently from edcca72 to c59e941 Compare August 25, 2023 09:55
@Priyanka-Kotturi

Copy link
Copy Markdown
Contributor Author

Thanks @chenbh for the suggestion, used the constant for the annotation key.

@chenbh chenbh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chenbh
chenbh merged commit 56623c5 into buildpacks-community:main Aug 25, 2023
neil-hickey pushed a commit to neil-hickey/kpack-cli that referenced this pull request Jan 13, 2026
…ue-269-add-buildid-for-kp-trigger

[Issue 269] Print the build number on the console output after triggering the image build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants