Check for existing service-binding before adding - #273
Merged
chenbh merged 1 commit intoDec 6, 2022
Merged
Conversation
Contributor
Author
|
Fixes: Allow Service Bindings using patch/save in kpack CLI #274 |
chenbh
requested changes
Dec 1, 2022
pksheldon4
force-pushed
the
feature/allow-service-bindings-during-save
branch
from
December 5, 2022 22:57
2429867 to
413181d
Compare
Contributor
Author
|
@chenbh - I made the change you requested. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where you can't use
kp image savewith a --service-binding if the Image Resource already included this service-binding. This was being handled for the --env option.