Only use a spinner on a tty #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise this command fails with errors about missing a tty when used in scripts on CI.
sj26
requested review from
mcncl,
lizrabuya,
PriyaSudip and
jykingston
as code owners
mcncl
approved these changes
Dec 5, 2024
|
Sadly this doesn't seem to have fixed my issue 😢 |
sj26
commented
Jul 6, 2025
| ) | ||
|
|
||
| func SpinWhile(name string, action func()) error { | ||
| if isatty.IsTerminal(os.Stdout.Fd()) { |
There was a problem hiding this comment.
This should have been:
Suggested change
| if isatty.IsTerminal(os.Stdout.Fd()) { | |
| if !isatty.IsTerminal(os.Stdout.Fd()) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use bk to push a package from GitHub Actions, but it failed:
https://github.com/sj26/github-actions-to-buildkite-packages-javascript-example/actions/runs/12133880719/job/33830150889#step:5:8
Pretty sure that message comes via
spinErr. I think it's because it's trying to start spinner, and that seems to require a tty.This wraps up the spinner a little function that checks if we're in a tty when starting a spinner, and skips the spinner if we're not.
I haven't attempted tests yet .. I just wanted to see if this works.
I did test this locally and could still push a package and it showed a spinner. I couldn't figure out quickly how to simulate a no-tty environment.