-
Notifications
You must be signed in to change notification settings - Fork 33
Adding Redacted Keys #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
clr182
wants to merge
28
commits into
next
Choose a base branch
from
PLAT-4543-AddRedactedKeys
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adding Redacted Keys #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tom Longridge <[email protected]>
Comment on lines
41
to
42
public String[] redactedKeys = new String[]{"password", "secret", "Authorization", "Cookie"}; | ||
public String[] filters = new String[]{"password", "secret", "Authorization", "Cookie"}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be appropriate to set this to the same instance rather than a different array with the same content. Just in case anyone is amending elements in the array.
Suggested change
public String[] redactedKeys = new String[]{"password", "secret", "Authorization", "Cookie"}; | |
public String[] filters = new String[]{"password", "secret", "Authorization", "Cookie"}; | |
public String[] redactedKeys = new String[]{"password", "secret", "Authorization", "Cookie"}; | |
public String[] filters = redactedKeys; |
Co-authored-by: Tom Longridge <[email protected]>
…ers` & `redactedKeys` separately in order to avoid edge-cases
b3da470
to
1b7b28c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Filtering config option is case sensitive and is no longer in line with our notifier spec; as such it should be deprecated in favour of
redactedKeys
.Design
Added
redactedKeys
configuration option, which is case insensitive, as a replacement for thefilters
configuration option. Additionally due to conflictions the defaultfilters
parameters were changed.Changeset
Added
redactedKeys
config option.Made
redactedKeys
case insensitive.Changed
filters
config default parameters from{"password", "secret", "Authorization", "Cookie"};
to
{"ipAddress", "logLevel"};
Set
refactedKeys
config default parameters to{"password", "secret", "Authorization", "Cookie"};
Testing
Added and updated tests for filtering mechanism and redactedKeys mechanism.