Skip to content

Add missing imports when not using clang modules#1284

Merged
nickdowell merged 1 commit into
bugsnag:nextfrom
keith:ks/add-missing-imports-when-not-using-clang-modules
Jan 19, 2022
Merged

Add missing imports when not using clang modules#1284
nickdowell merged 1 commit into
bugsnag:nextfrom
keith:ks/add-missing-imports-when-not-using-clang-modules

Conversation

@keith

@keith keith commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

If CLANG_ENABLE_MODULES=NO these imports are missing leading to
compiler errors.

If `CLANG_ENABLE_MODULES=NO` these imports are missing leading to
compiler errors.
@nickdowell nickdowell changed the base branch from master to next January 19, 2022 08:22

@nickdowell nickdowell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @keith!

nickdowell added a commit that referenced this pull request Jan 19, 2022
…sing-clang-modules

# Conflicts:
#	CHANGELOG.md
@nickdowell nickdowell merged commit 9aed5a1 into bugsnag:next Jan 19, 2022
@nickdowell nickdowell mentioned this pull request Jan 19, 2022
@luke-belton

Copy link
Copy Markdown

hey @keith - thanks again for this. We've released this in v6.16.1 of bugsnag-cocoa 🎉

@luke-belton luke-belton added the released This feature/bug fix has been released label Jan 19, 2022
@keith

keith commented Jan 19, 2022

Copy link
Copy Markdown
Contributor Author

Thank you!

@keith keith deleted the ks/add-missing-imports-when-not-using-clang-modules branch January 19, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released This feature/bug fix has been released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants