Update to protocolbuffers/protobuf v34.0#1385
Merged
Merged
Conversation
Upgrade the upstream protoc from v33.2.0 to v34.0.0. protoc v34.0 introduces EDITION_UNSTABLE (9999) as a sandbox for in-development features. Follow the approach upstream protobuf-go took and special-case this edition in the runtime and plugin edition-range checks, rather than treating it as a hard error. - Add Edition.EDITION_UNSTABLE to SupportedEdition. - In getFileEdition, accept EDITION_UNSTABLE alongside the known editions. - In resolveFeature, fall back to maximumEdition (EDITION_2024) feature defaults when the file is EDITION_UNSTABLE. - In protoplugin's schema.ts, carve EDITION_UNSTABLE out of the min/max check so plugins do not error when protoc passes an UNSTABLE file through with --experimental_editions. Regenerated protobuf-test fixtures against protoc v34.0.
srikrsna-buf
approved these changes
Apr 20, 2026
Comment on lines
+253
to
+255
| // EDITION_UNSTABLE is a sandbox for in-development features; accept | ||
| // it regardless of the plugin's min/max bounds. | ||
| if (edition !== Edition.EDITION_UNSTABLE) { |
Contributor
There was a problem hiding this comment.
continue on the inverse will reduce nesting.
emcfarlane
changed the title
Member
Sorry, missed that. Works for me. |
timostamm
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates to protocolbuffers/protobuf v34.0. Conformance testing will be done as a follow up.
Continuing on from #1308 the
EDITION_UNSTABLEenum is now special cased in the runtime and plugin edition-range checks, rather than treating it as a hard error. An unstable edition will fall back to themaximumEdition(currentlyEDITION_2024) feature to allow for testing.Regenerated protobuf-test fixtures against v34.0.
Closes #1361