Gracefully handle Number for BigInt fields#1346
Merged
timostamm merged 1 commit intoJan 23, 2026
Merged
Conversation
srikrsna-buf
approved these changes
Jan 23, 2026
timostamm
deleted the
tstamm/Gracefully-handle-Number-for-BigInt-fields
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Number value is assigned to a BigInt field (e.g. protobuf field int64),
toJsonraises an error. The error message is confusing because the underlying code does support serialization of Number, and does not provide meaningful error details.This PR relaxes the validation in
toJsonto gracefully handle serialization of integral Number values.Fixes #1345.