Skip to content

Conversation

mfridman
Copy link
Member

@mfridman mfridman commented Jul 10, 2024

Includes

Fix #1340

Includes

- connectrpc/kotlin:v0.7.0
- community/mercari-grpc-federation:v1.0.3
- apple/swift:v1.27.0 (with new patch)
}
}

+ let extraModuleImports: [String]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved some of the constants and variables towards the "top" to minimize conflicts.

@mfridman
Copy link
Member Author

mfridman commented Jul 10, 2024

apple/swift generated code diff between v1.26.0 and v1.27.0

buf_connect_demo_eliza_v1_eliza.pb.swift

I believe this looks okay, where they changed how the Sendable protocol is defined. Moving it out of extensions and directly into the struct definition.

38c38
< public struct Buf_Connect_Demo_Eliza_V1_SayRequest {
---
> public struct Buf_Connect_Demo_Eliza_V1_SayRequest: Sendable {
51c51
< public struct Buf_Connect_Demo_Eliza_V1_SayResponse {
---
> public struct Buf_Connect_Demo_Eliza_V1_SayResponse: Sendable {
64c64
< public struct Buf_Connect_Demo_Eliza_V1_ConverseRequest {
---
> public struct Buf_Connect_Demo_Eliza_V1_ConverseRequest: Sendable {
77c77
< public struct Buf_Connect_Demo_Eliza_V1_ConverseResponse {
---
> public struct Buf_Connect_Demo_Eliza_V1_ConverseResponse: Sendable {
90c90
< public struct Buf_Connect_Demo_Eliza_V1_IntroduceRequest {
---
> public struct Buf_Connect_Demo_Eliza_V1_IntroduceRequest: Sendable {
103c103
< public struct Buf_Connect_Demo_Eliza_V1_IntroduceResponse {
---
> public struct Buf_Connect_Demo_Eliza_V1_IntroduceResponse: Sendable {
115,123d114
< #if swift(>=5.5) && canImport(_Concurrency)
< extension Buf_Connect_Demo_Eliza_V1_SayRequest: @unchecked Sendable {}
< extension Buf_Connect_Demo_Eliza_V1_SayResponse: @unchecked Sendable {}
< extension Buf_Connect_Demo_Eliza_V1_ConverseRequest: @unchecked Sendable {}
< extension Buf_Connect_Demo_Eliza_V1_ConverseResponse: @unchecked Sendable {}
< extension Buf_Connect_Demo_Eliza_V1_IntroduceRequest: @unchecked Sendable {}
< extension Buf_Connect_Demo_Eliza_V1_IntroduceResponse: @unchecked Sendable {}
< #endif  // swift(>=5.5) && canImport(_Concurrency)
< 

@mfridman mfridman requested a review from pkwarren July 10, 2024 14:26
WORKDIR /app
RUN curl -fsSL -o /app/protoc-gen-connect-kotlin.jar https://repo1.maven.org/maven2/com/connectrpc/protoc-gen-connect-kotlin/0.7.0/protoc-gen-connect-kotlin-0.7.0.jar

FROM gcr.io/distroless/java17-debian12:latest@sha256:c8c2c236c63d7652b707a05b02d0259db91d5feb357e9dc53942f73c2e001088
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should squash layers here similar to other builds.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 1ea0fb8, in case you want to review that separately

@mfridman mfridman merged commit 974c7a8 into main Jul 10, 2024
@mfridman mfridman deleted the mf/fetcher branch July 10, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected Fetch latest versions failure
2 participants