Skip to content

btcutil: Add library functions for BIP-0352 silent payment _send_ support #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

guggero
Copy link
Collaborator

@guggero guggero commented Sep 1, 2024

Adds library/API functionality for Silent Payment send support.

Implements the following BIPs (or pull requests to BIPs):

Goal is to address send support first as that's rather straightforward. Receive support is much more involved as it requires scanning the chain in a specific manner.

@coveralls
Copy link

coveralls commented Oct 20, 2024

Pull Request Test Coverage Report for Build 14137608998

Details

  • 515 of 722 (71.33%) changed or added relevant lines in 9 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 56.803%

Changes Missing Coverage Covered Lines Changed/Added Lines %
btcutil/silentpayments/output.go 52 58 89.66%
btcutil/silentpayments/secp.go 40 51 78.43%
btcutil/psbt/partial_output.go 27 39 69.23%
btcutil/psbt/partial_input.go 32 46 69.57%
btcutil/psbt/psbt.go 40 54 74.07%
btcutil/psbt/silentpayments.go 40 58 68.97%
btcutil/silentpayments/input.go 81 102 79.41%
btcutil/silentpayments/dleq.go 104 131 79.39%
btcutil/silentpayments/address.go 99 183 54.1%
Files with Coverage Reduction New Missed Lines %
peer/peer.go 1 74.38%
Totals Coverage Status
Change from base Build 14076739198: 0.3%
Covered Lines: 31572
Relevant Lines: 55582

💛 - Coveralls

@guggero guggero force-pushed the silent-payments branch 4 times, most recently from 2a9a931 to 996c4d3 Compare December 31, 2024 08:19
@saubyk saubyk added this to the v0.25 milestone Feb 13, 2025
@saubyk saubyk requested a review from kcalvinalvin February 18, 2025 00:48
@guggero guggero marked this pull request as ready for review March 28, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants