Skip to content

Uncaught error (sync nor async) if main field is not a string #178

@unlight

Description

@unlight

How to repeat:

git clone https://gist.github.com/14c93c133d9657411e95959e22e32570.git main-is-not-a-string
cd main-is-not-a-string
npm i
node resolve-material-design-iconic-font.js
const resolve = require('resolve');

try {
	resolve('material-design-iconic-font', (err) => {
		console.log('async err', err);
	});	
} catch (err) {
	console.log('sync err', err);
} 

Actual:

path.js:39
    throw new ERR_INVALID_ARG_TYPE('path', 'string', path);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type object
    at assertPath (path.js:39:11)
    at Object.resolve (path.js:168:7)
    at \Dev\browserify-resolve-zavoloklom-material-design-iconic-font-issue-111\node_modules\resolve\lib\async.js:164:37
    at FSReqWrap.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:53:3)

Expected:
Error should be caught in callback or in catch

resolve: 1.8.1
node v10.8.0

Related issues:
unlight/sublime-import-helper#61
zavoloklom/material-design-iconic-font#111

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions