Dbp table mismatch #1798
Merged
Dbp table mismatch #1798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OK, this is super weird. I'm not sure how this was working before, but it certainly was, unless somehow node-canvas behaves differently in webviews than in real browser tabs. Also I'm not sure how new-image-things ever passed on Travis. But it sure seems like node-canvas does not in fact provide an Image constructor when run in-browser -- canvas.Image is clearly undefined and only the default browser canvas APIs are there when we import it this way. So, we have to do the polyfill bit ourselves and make sure `Image` is correctly set up as the nonstandard canvas.Image from node-canvas when offline and to the browser's window.Image in browsers
…to opts. fix cli text-based render-reason
…ig-headers To avoid potential clashes with different clients, it's better if the new spec for these tuples is that the new field is at the end, and to allow the old or new length. Also pragmatically this avoids coming up with a good answer for gdrive-sheets while still enjoying this runtime change for CSV loading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was #1788
Moved to a pyret-lang branch for quicker dev for me.