Skip to content

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 18, 2025

  • Edit (e) command has a forceful alternative (E), but read (r) command doesn't (since r doesn't destroy the buffer)
  • edEdit() continues to handle e and E ($QuestionsMode param determines the mode)
  • r and e commands both use the saved filename if no argument is provided
  • Command arguments starting with '!' now call function init_pipe(), which rejects NUL and provides an argument list to pipe form of open()
  • Also add helper functions open_file_ro() and readin_lines() for common code
  • r command never updates $RememberedFilename; e command updates it if a file argument was provided
  • test1: "e !this" --> bad command, show error, buffer unchanged
  • test2: "r !this" --> same as test1
  • test3: "e !ls -l" --> buffer replaced with ls output if buffer is clean
  • test4: "E !echo E" --> buffer replaced with echo output unconditionally
  • test5: "1,2e a.s" --> invalid command, e doesn't take any addresses
  • test6: "0r a.s" --> file a.s is read into the beginning of the buffer

* Edit (e) command has a forceful alternative (E), but read (r) command doesn't (since r doesn't destroy the buffer)
* edEdit() continues to handle e and E ($QuestionsMode param determines the mode)
* r and e commands both use the saved filename if no argument is provided
* Command arguments starting with '!' now call function init_pipe(), which rejects NUL and provides an argument list to pipe form of open()
* Also add helper functions open_file_ro() and readin_lines() for common code
* r command never updates $RememberedFilename; e command updates it if a file argument was provided
* test1: "e !this" --> bad command, show error, buffer unchanged
* test2: "r !this" --> same as test1
* test3: "e !ls -l" --> buffer replaced with ls output if buffer is clean
* test4: "E !echo E" --> buffer replaced with ls output unconditionally
* test5: "1,2e a.s" --> invalid command, e doesn't take any addresses
* test6: "0r a.s" --> file a.s is read into the beginning of the buffer
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Jan 18, 2025
@mknos mknos temporarily deployed to automated_testing January 18, 2025 13:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 13:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 13:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 13:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 13:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 13:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 13:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 13:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 13:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 13:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 13:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 13:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 13:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 13:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 13:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 13:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 13:55 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jan 18, 2025

Pull Request Test Coverage Report for Build 12844597261

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.389%

Totals Coverage Status
Change from base Build 12843752400: 0.0%
Covered Lines: 353
Relevant Lines: 481

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 18, 2025

Pull Request Test Coverage Report for Build 12844597257

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 74.12%

Totals Coverage Status
Change from base Build 12843752400: 0.7%
Covered Lines: 358
Relevant Lines: 483

💛 - Coveralls

@briandfoy briandfoy merged commit 27025b0 into briandfoy:master Jan 18, 2025
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Jan 18, 2025
@briandfoy briandfoy removed the Priority: low get to this whenever label Jan 18, 2025
@briandfoy briandfoy added the Status: accepted The fix is accepted label Jan 18, 2025
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants