-
Notifications
You must be signed in to change notification settings - Fork 53
ed: factor r command out of edEdit() #922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Edit (e) command has a forceful alternative (E), but read (r) command doesn't (since r doesn't destroy the buffer) * edEdit() continues to handle e and E ($QuestionsMode param determines the mode) * r and e commands both use the saved filename if no argument is provided * Command arguments starting with '!' now call function init_pipe(), which rejects NUL and provides an argument list to pipe form of open() * Also add helper functions open_file_ro() and readin_lines() for common code * r command never updates $RememberedFilename; e command updates it if a file argument was provided * test1: "e !this" --> bad command, show error, buffer unchanged * test2: "r !this" --> same as test1 * test3: "e !ls -l" --> buffer replaced with ls output if buffer is clean * test4: "E !echo E" --> buffer replaced with ls output unconditionally * test5: "1,2e a.s" --> invalid command, e doesn't take any addresses * test6: "0r a.s" --> file a.s is read into the beginning of the buffer
Pull Request Test Coverage Report for Build 12844597261Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 12844597257Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Program: ed
The ed program
Status: released
there is a new release with this fix
Type: enhancement
improve a feature that already exists
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.