Skip to content

ed: 0k is not OK #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2025
Merged

ed: 0k is not OK #921

merged 1 commit into from
Jan 18, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 18, 2025

  • Avoid saving address 0 as a "marked address"
  • When edMark() was first written I didn't pick up that this usage was not allowed in other versions of ed
  • test1: 1kx --> save address 1 as mark "k", valid if the buffer is not empty
  • test2: 0ky --> save address 0, invalid
  • test3: kz --> save current address as mark "z", valid if the buffer is not empty

@mknos
ed: k0 is invalid
c600f38 
* Avoid saving address 0 as a "marked address"
* When edMark() was first written I didn't pick up that this usage was not allowed in other versions of ed
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Jan 18, 2025
@mknos mknos temporarily deployed to automated_testing January 18, 2025 09:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 09:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 09:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 09:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 09:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 09:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 09:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 09:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 09:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 09:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 09:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 09:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 09:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 09:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 09:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 09:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 09:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 09:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 09:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 18, 2025 09:04 — with GitHub Actions Inactive
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12842667579

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.389%
Totals Coverage Status
Change from base Build 12842366473: -0.7%
Covered Lines: 353
Relevant Lines: 481
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Jan 18, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12842667579

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.389%
Totals Coverage Status
Change from base Build 12842366473: -0.7%
Covered Lines: 353
Relevant Lines: 481
💛 - Coveralls

@briandfoy briandfoy merged commit 8513145 into briandfoy:master Jan 18, 2025
21 of 23 checks passed
@briandfoy briandfoy self-assigned this Jan 18, 2025
@briandfoy briandfoy added Status: accepted The fix is accepted Type: bug an existing feature does not work and removed Priority: low get to this whenever Type: enhancement improve a feature that already exists labels Jan 18, 2025
@briandfoy
Copy link
Owner

changes: Avoid saving address 0 as a "marked address"

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy