Skip to content

tsort: '-' argument is not special #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2025
Merged

tsort: '-' argument is not special #905

merged 1 commit into from
Jan 6, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 6, 2025

  • Standards document does not require that a '-' argument is interpreted as stdin [1]
  • Follow BSD semantics and treat '-' as a regular file argument (tested against OpenBSD)
  • Previous special meaning of '-' was not documented in the pod manual; add explicit text to explain when stdin is used
  1. https://pubs.opengroup.org/onlinepubs/9699919799/utilities/tsort.html

@mknos
tsort: '-' argument is not special
0de7cd4 
* Standards document does not require that a '-' argument is interpreted as stdin [1]
* Follow BSD semantics and treat '-' as a regular file argument (tested against OpenBSD)

1. https://pubs.opengroup.org/onlinepubs/9699919799/utilities/tsort.html
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: tsort The sort program labels Jan 6, 2025
@mknos mknos temporarily deployed to automated_testing January 6, 2025 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 6, 2025 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 6, 2025 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 6, 2025 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 6, 2025 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 6, 2025 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 6, 2025 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 6, 2025 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 6, 2025 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 6, 2025 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 6, 2025 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 6, 2025 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 6, 2025 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 6, 2025 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 6, 2025 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 6, 2025 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 6, 2025 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 6, 2025 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 6, 2025 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 6, 2025 03:20 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jan 6, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12625892462

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 72.464%
Files with Coverage Reduction New Missed Lines %
bin/units 3 69.91%
Totals Coverage Status
Change from base Build 12616265367: -0.7%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy merged commit c2521ec into briandfoy:master Jan 6, 2025
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: don't treat - as a special filename for stdin

@briandfoy briandfoy self-assigned this Jan 6, 2025
@briandfoy briandfoy added Status: accepted The fix is accepted Type: compatability make it work like GNU or BSD and removed Priority: low get to this whenever Type: enhancement improve a feature that already exists labels Jan 6, 2025
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: tsort The sort program Status: released there is a new release with this fix Type: compatability make it work like GNU or BSD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy