Skip to content

clear: handling OSPEED is not needed #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2025
Merged

clear: handling OSPEED is not needed #894

merged 1 commit into from
Jan 2, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 2, 2025

  • The OSPEED option being passed to Tgetent() is not required for clearing the screen
  • Win32 perl might not have a working Term::Cap, so move the Tgetent() call into the eval just in case
  • Tested on Linux and OpenBSD

@mknos
clear: handling OSPEED is not needed
8da8b5a 
* The OSPEED option being passed to Tgetent() is not required for clearing the screen
* Win32 perl might not have a working Term::Cap, so move the Tgetent() call into the eval just in case
* Tested on Linux and OpenBSD
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: clear The clear program labels Jan 2, 2025
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:15 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jan 2, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12576561412

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.464%
Totals Coverage Status
Change from base Build 12566564471: 0.0%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy self-assigned this Jan 2, 2025
@briandfoy
Copy link
Owner

I see this, and I'll test it on Windows then merge if there are no problems.

@briandfoy
Copy link
Owner

This works for me on Windows 10 using:

  • ComEmu
  • PowerShell
  • Command Prompt

I think all of these are using the same underlying code to manage the window.

@briandfoy briandfoy merged commit 978e1bc into briandfoy:master Jan 2, 2025
23 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jan 2, 2025
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@briandfoy briandfoy

Labels
Program: clear The clear program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy