Skip to content

primes: raise error for start>end #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2025
Merged

primes: raise error for start>end #891

merged 1 commit into from
Jan 1, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 1, 2025

  • If run with 2 arguments, primes are displayed for a range from Start to End
  • Normally an error was raised if End was smaller than Start, but the value of 0 was resulting in a default value unexpectedly
  • Convert maximum to a constant so it could be changed easier to 64 bits (no dynamic size calculation is being done but at least the user can patch the one constant)
  • Original test: perl primes 10 0

@mknos
primes: raise error for start>end
c6fd838 
* If run with 2 arguments, primes are displayed for a range from Start to End
* Normally an error was raised if End was smaller than Start, but the value of 0 was resulting in a default value unexpectedly
* Convert maximum to a constant so it could be changed easier to 64 bits (no dynamic size calculation is being done but at least the user can patch the one constant)
* Original test: perl primes 10 0
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:28 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: primes The primes program labels Jan 1, 2025
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:28 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jan 1, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12566299430

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.464%
Totals Coverage Status
Change from base Build 12398496491: 0.0%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy self-assigned this Jan 1, 2025
@briandfoy briandfoy merged commit 2704d67 into briandfoy:master Jan 1, 2025
23 checks passed
@briandfoy
Copy link
Owner

changes: disallow 0 as an upper bound (inadvertently chooses the default)

@briandfoy briandfoy added Status: accepted The fix is accepted Type: bug an existing feature does not work and removed Priority: low get to this whenever Type: enhancement improve a feature that already exists labels Jan 1, 2025
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: primes The primes program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy