Skip to content

paste: shortcut loop #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2024
Merged

paste: shortcut loop #882

merged 1 commit into from
Dec 18, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 18, 2024

  • Each iteration of the input loop initially checks if any input files still have data to read
  • Leave inner file check loop early if 1st file is still ok (no need to check 2nd file)
  • I confirmed that the same output is produced as for an older commit; my test used 2 input files of different length

@mknos
paste: shortcut loop
cae5f2d 
* Each iteration of input loop initially checks if any input files still have data to read
* Leave inner file check loop early if 1st file is still ok (no need to check 2nd file)
* I confirmed that the same output is produced as for an older commit; my test used 2 input files of different length
@mknos mknos temporarily deployed to automated_testing December 18, 2024 03:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 03:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 03:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 03:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 03:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 03:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 03:36 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: paste The paste command labels Dec 18, 2024
@mknos mknos temporarily deployed to automated_testing December 18, 2024 03:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 03:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 03:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 03:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 03:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 03:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 03:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 03:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 03:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 03:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 03:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 03:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 03:37 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Dec 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12385880027

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 72.464%
Files with Coverage Reduction New Missed Lines %
bin/units 3 69.91%
Totals Coverage Status
Change from base Build 12379357612: -0.7%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy merged commit 9d3a73e into briandfoy:master Dec 18, 2024
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Dec 18, 2024
@briandfoy briandfoy removed the Priority: low get to this whenever label Dec 18, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted Type: bug an existing feature does not work and removed Type: enhancement improve a feature that already exists labels Dec 18, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: paste The paste command Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy