Skip to content

lock: re-enable term echo #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2024
Merged

lock: re-enable term echo #881

merged 1 commit into from
Dec 18, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 18, 2024

  • When testing lock with a 1 minute timeout, my terminal text was invisible after lock times out and exits
  • In the alarm handler, be careful to enable echo before the program finishes

@mknos
lock: re-enable term echo
83fc3ef 
* When testing lock with a 1 minute timeout, my terminal text was invisible after lock times out and exits
* In the alarm handler, be careful to enable echo before the program finishes
@mknos mknos temporarily deployed to automated_testing December 18, 2024 01:50 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: lock The lock program labels Dec 18, 2024
@mknos mknos temporarily deployed to automated_testing December 18, 2024 01:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 01:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 01:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 01:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 01:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 01:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 01:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 01:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 01:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 01:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 01:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 01:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 01:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 01:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 01:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 01:51 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 01:51 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 01:52 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 18, 2024 01:52 — with GitHub Actions Inactive
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12384818274

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 72.464%
Files with Coverage Reduction New Missed Lines %
bin/units 3 69.91%
Totals Coverage Status
Change from base Build 12379357612: -0.7%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Dec 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12384818274

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 72.464%
Files with Coverage Reduction New Missed Lines %
bin/units 3 69.91%
Totals Coverage Status
Change from base Build 12379357612: -0.7%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy merged commit d2a7d36 into briandfoy:master Dec 18, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: re-enable term echo after lockout

@briandfoy briandfoy self-assigned this Dec 18, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted Type: bug an existing feature does not work and removed Priority: low get to this whenever Type: enhancement improve a feature that already exists labels Dec 18, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: lock The lock program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy