Skip to content

which: retire dir-separator variable #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2024
Merged

which: retire dir-separator variable #877

merged 1 commit into from
Dec 17, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 17, 2024

  • As done in other scripts, join filename to base directory with catfile() because it abstracts some OS details
  • Now the global $file_sep can be removed
  • I didn't test this on Mac OSX or old MacOS, but I expect catfile() won't do any harm for OSX case

@mknos
which: retire dir-separator variable
1d377c3 
* As done in other scripts, join filename to base directory with catfile() because it abstracts some OS details
* Now the global $file_sep can be removed
* I didn't test this on Mac OSX or old MacOS, but I expect catfile() won't do any harm for OSX case
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: which The which program labels Dec 17, 2024
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:49 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Dec 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12364772194

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 72.464%
Totals Coverage Status
Change from base Build 12352391146: -0.7%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy self-assigned this Dec 17, 2024
@briandfoy briandfoy merged commit 06ea94a into briandfoy:master Dec 17, 2024
22 of 23 checks passed
@briandfoy briandfoy removed the Priority: low get to this whenever label Dec 17, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted Type: bug an existing feature does not work Type: modernization updating programs to current practices and removed Type: enhancement improve a feature that already exists Type: bug an existing feature does not work labels Dec 17, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: which The which program Status: released there is a new release with this fix Type: modernization updating programs to current practices
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy