Skip to content

ed: update current line in undo #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2024
Merged

ed: update current line in undo #871

merged 1 commit into from
Dec 9, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 9, 2024

  • GNU and OpenBSD versions restore line number at same time as restoring editor buffer in undo operation
  • This is needed because $CurrentLineNum might not point to a valid address anymore
  • For example, run "$a" command to append lines to end of buffer (currentLine becomes new maxLine), then run "u" to undo the append (buffer shrinks, maxLine reverts)

@mknos
ed: update current line in undo
169a077 
* GNU and OpenBSD versions restore line number at same time as restoring editor buffer in undo operation
* This is needed because $CurrentLineNum might not point to a valid address anymore
* For example, run "$a" command to append lines to end of buffer (currentLine becomes new maxLine), then run "u" to undo the append (buffer shrinks, maxLine reverts)
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Dec 9, 2024
@mknos mknos temporarily deployed to automated_testing December 9, 2024 08:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 08:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 08:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 08:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 08:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 08:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 08:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 08:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 08:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 08:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 08:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 08:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 08:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 08:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 08:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 08:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 08:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 08:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 08:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 08:51 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Dec 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12232049487

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 72.464%
Totals Coverage Status
Change from base Build 12229907280: -0.7%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy merged commit ff93712 into briandfoy:master Dec 9, 2024
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Dec 9, 2024
@briandfoy briandfoy removed the Priority: low get to this whenever label Dec 9, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Dec 9, 2024
@briandfoy
Copy link
Owner

briandfoy commented Dec 9, 2024 •
edited
Loading

changes: update current line in undo

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy