Skip to content

glob: don't raise error for unknown user with '~' #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2024
Merged

glob: don't raise error for unknown user with '~' #867

merged 1 commit into from
Dec 9, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 9, 2024

  • A tilde can optionally be followed by a username
  • If a provided username is not found, treat the input as no-match instead of raising an error
  • This is consistent with Linux/bash, OpenBSD/ksh and the perl builtin glob() function
  • If '~' appears without a username, it is substituted for the current user's home directory
  • Remove some '&' sigils from &xzy() function calls---glob() now gets called with fully qualified name
%echo ~mail/a # valid user
/var/mail/a
%echo ~mayel/a # not found
~mayel/a
%echo ~/a
/home/pi/a

@mknos
glob: don't raise error for unknown user with '~'
4c50e2b 
* A tilde can optionally be followed by a username
* If a provided username is not found, treat the input as no-match instead of raising an error
* This is consistent with Linux/bash, OpenBSD/ksh and the perl builtin glob() function
* If '~' appears without a username, it is substituted for the current user's home directory

%echo ~mail/a # valid user
/var/mail/a
%echo ~mayel/a # not found
~mayel/a
%echo ~/a
/home/pi/a
@mknos mknos temporarily deployed to automated_testing December 9, 2024 01:27 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: glob The glob program labels Dec 9, 2024
@mknos mknos temporarily deployed to automated_testing December 9, 2024 01:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 01:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 01:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 01:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 01:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 01:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 01:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 01:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 01:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 01:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 01:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 01:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 01:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 01:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 01:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 01:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 01:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 01:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 01:28 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Dec 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12227207151

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 73.196%
Totals Coverage Status
Change from base Build 12203109856: 0.7%
Covered Lines: 355
Relevant Lines: 485
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12227207151

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.464%
Totals Coverage Status
Change from base Build 12203109856: 0.0%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

briandfoy
briandfoy approved these changes Dec 9, 2024
View reviewed changes
bin/glob
@@ -180,7 +180,7 @@ use File::Spec;

use vars qw($VERSION @ISA @EXPORT @EXPORT_OK);

$VERSION = 1.2_06;
$VERSION = 1.2_07;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably make this a non-trial version unless you have a reason you'd like to keep it as such.

@briandfoy briandfoy merged commit 7603aa2 into briandfoy:master Dec 9, 2024
23 checks passed
@briandfoy
Copy link
Owner

changes: with ~someuser, if that user is not found, treat it as a non-match instead of an error

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Dec 9, 2024
@briandfoy briandfoy self-assigned this Dec 9, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: glob The glob program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy