Skip to content

tail: portable -f DIR #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2024
Merged

tail: portable -f DIR #856

merged 1 commit into from
Dec 4, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 4, 2024

  • tail -f flag changes how all the file arguments are handled, i.e. tail_f() function is called
  • When passing directory arguments to tail -f, @dirlist contains all the directory args
  • get_existing_files() is called for each directory
  • Switch get_existing_files() to use catfile() to join directory name with filenames from readdir()---this removes the assumption that the OS uses '/' as a directory separator

@mknos
tail: portable -f DIR
dde9066 
* tail -f flag changes how all the file arguments are handled, i.e. tail_f() function is called
* When passing directory arguments to tail -f, dirlist-list is contains all the directory args
* get_existing_files() is called for each directory
* Switch get_existing_files() to use catfile() to join directory name with filenames from readdir()---this removes the assumption that the OS uses '/' as a directory separator
@mknos mknos temporarily deployed to automated_testing December 4, 2024 03:28 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: tail The tail program labels Dec 4, 2024
@mknos mknos temporarily deployed to automated_testing December 4, 2024 03:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 03:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 03:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 03:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 03:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 03:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 03:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 03:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 03:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 03:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 03:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 03:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 03:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 03:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 03:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 03:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 03:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 03:28 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 4, 2024 03:28 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Dec 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12152461199

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 72.464%
Totals Coverage Status
Change from base Build 12140302199: -0.7%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy self-assigned this Dec 4, 2024
@briandfoy briandfoy merged commit 830c746 into briandfoy:master Dec 4, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: use File::Spec to construct paths portably

@briandfoy briandfoy added Status: accepted The fix is accepted Status: released there is a new release with this fix and removed Priority: low get to this whenever Status: accepted The fix is accepted labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: tail The tail program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy