Skip to content

glob: unused function #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2024
Merged

glob: unused function #848

merged 1 commit into from
Dec 2, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 2, 2024

  • globtest() wasn't called and this kind of test probably belongs in a separate harness script
%for glb in 'x*' 'y*'; do echo -n 'A: '; echo $(perl glob "$glb"); echo -n 'B: '; echo $glb; echo; done
A: x.bc x.pl xaaa xaab xaac xargs xx xxx xxyy
B: xaaa xaab xaac xargs x.bc x.pl xx xxx xxyy

A: yes yo2 yoooo
B: yes yo2 yoooo

@mknos
glob: unused function
23f2c80 
* globtest() wasn't called and this kind of test probably belongs in a separate harness script

%for glb in 'x*' 'y*'; do echo -n 'A: '; echo $(perl glob "$glb"); echo -n 'B: '; echo $glb; echo; done
A: x.bc x.pl xaaa xaab xaac xargs xx xxx xxyy
B: xaaa xaab xaac xargs x.bc x.pl xx xxx xxyy

A: yes yo2 yoooo
B: yes yo2 yoooo
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: glob The glob program labels Dec 2, 2024
@mknos mknos temporarily deployed to automated_testing December 2, 2024 02:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 2, 2024 02:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 2, 2024 02:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 2, 2024 02:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 2, 2024 02:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 2, 2024 02:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 2, 2024 02:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 2, 2024 02:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 2, 2024 02:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 2, 2024 02:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 2, 2024 02:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 2, 2024 02:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 2, 2024 02:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 2, 2024 02:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 2, 2024 02:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 2, 2024 02:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 2, 2024 02:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 2, 2024 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 2, 2024 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 2, 2024 02:07 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Dec 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12111355714

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.464%
Totals Coverage Status
Change from base Build 12096063947: 0.0%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy self-assigned this Dec 2, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever Type: enhancement improve a feature that already exists labels Dec 2, 2024
@briandfoy briandfoy added the Type: modernization updating programs to current practices label Dec 2, 2024
@briandfoy briandfoy merged commit 6a6fcc0 into briandfoy:master Dec 2, 2024
23 checks passed
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: glob The glob program Status: released there is a new release with this fix Type: modernization updating programs to current practices
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy