Skip to content

install: -m0 option is valid #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2024
Merged

install: -m0 option is valid #837

merged 1 commit into from
Nov 25, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 25, 2024

  • I might want to install something but make it temporarily not accessible --- "install -m 0 file dir"
  • Numeric file mode 0 should be passed to chmod() but it was being ignored
  • Problem1: modify_file() assumes $mode is not zero
  • Problem2: install_files() assumes $opt{m} is not zero
  • Apply same logic in install_dirs() because that seems wrong too
  • In install_files(), calculating the symbolic file mode is not required in the "non-unix" case, where modify_file() would never be called (I noticed this when comparing install_dirs())

@mknos
install: -m0 option is valid
b153944 
* I might want to install something but make it temporarily not accessible --- "install -m 0 file dir"
* Numeric file mode 0 should be passed to chmod() but it was being ignored
* Problem1: modify_file() assumes $mode is not zero
* Problem2: install_files() assumes $opt{m} is not zero
* Apply same logic in install_dirs() because that seems wrong too
* In install_files(), calculating the symbolic file mode is not required in the "non-unix" case, where modify_file() would never be called (I noticed this when comparing install_dirs())
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: install The install program labels Nov 25, 2024
@mknos mknos temporarily deployed to automated_testing November 25, 2024 05:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 05:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 05:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 05:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 05:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 05:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 05:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 05:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 05:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 05:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 05:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 05:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 05:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 05:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 05:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 05:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 05:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 05:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 05:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 05:26 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12003839638

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11992872685: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit d11cf9a into briandfoy:master Nov 25, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: allow mode to be 0 (make thing temporarily unavailable even when installed)

@briandfoy briandfoy self-assigned this Nov 25, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted Type: bug an existing feature does not work and removed Priority: low get to this whenever Type: enhancement improve a feature that already exists labels Nov 25, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: install The install program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy