Skip to content

ed: clarify global var names #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2024
Merged

ed: clarify global var names #834

merged 1 commit into from
Nov 25, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 25, 2024

Rename 2 globals for consistency

  • $EXTENDED_MESSAGES looked like a constant but is in fact toggled in edHelp()
  • $SupressCounts becomes $Scripted because scripts calling ed non-interactively often run "ed -s"; name taken from BSD ed [1]
  1. http://cvsweb.netbsd.org/bsdweb.cgi/src/bin/ed/main.c?annotate=1.30.2.2

@mknos
ed: clarify global var names
70da9c1 
Rename 2 globals for consistency
* $EXTENDED_MESSAGES looked like a constant but is in fact toggled in edHelp()
* $SupressCounts becomes $Scripted because scripts calling ed non-interactively often run "ed -s"; name taken from BSD ed [1]

1. http://cvsweb.netbsd.org/bsdweb.cgi/src/bin/ed/main.c?annotate=1.30.2.2
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Nov 25, 2024
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:04 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:04 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:04 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:04 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:04 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:04 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:04 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:04 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:04 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:04 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:04 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:04 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:04 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:04 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:04 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:04 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:04 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:04 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:04 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:05 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12000736895

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.805%
Totals Coverage Status
Change from base Build 11992872685: 0.0%
Covered Lines: 355
Relevant Lines: 481
💛 - Coveralls

@briandfoy briandfoy merged commit 5b73b94 into briandfoy:master Nov 25, 2024
23 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 25, 2024
@briandfoy briandfoy self-assigned this Nov 25, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy